configurable request header for determining peer#6063
Merged
Conversation
rnewson
force-pushed
the
custom-peer-header
branch
from
July 19, 2026 19:17
b615fe3 to
fb66a58
Compare
rnewson
marked this pull request as ready for review
July 19, 2026 19:17
rnewson
force-pushed
the
custom-peer-header
branch
2 times, most recently
from
July 19, 2026 20:20
4f7db1c to
37eade8
Compare
nickva
reviewed
Jul 20, 2026
nickva
left a comment
nickva
left a comment
Contributor
There was a problem hiding this comment.
Well done! Just a left a few notes. Some are nits and some are questions I had.
An interesting aspect here might be that if users would set a peer_header they should be warned that they should also prevent clients from controlling that header. The proxy should clear that clients' header, and replace it with its own. Otherwise, it would be a trivial for clients to bypass the lockout by sending random values for the header they now control.
rnewson
force-pushed
the
custom-peer-header
branch
4 times, most recently
from
July 20, 2026 15:54
d756ca9 to
8353785
Compare
nickva
reviewed
Jul 20, 2026
nickva
left a comment
nickva
left a comment
Contributor
There was a problem hiding this comment.
Look much tidier. Just a few more notes and maybe we can do some deduplication, still
rnewson
force-pushed
the
custom-peer-header
branch
2 times, most recently
from
July 20, 2026 18:40
67a778a to
4ae1bbd
Compare
rnewson
force-pushed
the
custom-peer-header
branch
from
July 20, 2026 19:17
4ae1bbd to
307e4d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Allow peer determination by a custom header, useful when CouchDB is behind a reverse proxy or load balancer.
In the absence of the header the usual logic is used to determine peer (the x-forwarded-for header logic in mochiweb).
Testing recommendations
covered by tests.
Related Issues or Pull Requests
#6052
Checklist
rel/overlay/etc/default.inisrc/docsfolder